Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java API: CreateIndexRequestBuilder.addMapping should throw exc if that type already has a mapping #7231

Closed
mikemccand opened this issue Aug 12, 2014 · 0 comments
Closed

Java API: CreateIndexRequestBuilder.addMapping should throw exc if that type already has a mapping #7231

mikemccand opened this issue Aug 12, 2014 · 0 comments
Assignees
@mikemccand
Labels
>enhancement v1.4.0.Beta1 v2.0.0-beta1

Comments

@mikemccand
Copy link
Contributor

I think it's trappy today, that .addMapping makes it seem like you can merge in mappings for different fields in the same type, whereas what it actually does is silently overwrite any previous .addMapping for that type.
@mikemccand mikemccand self-assigned this Aug 12, 2014
@mikemccand mikemccand mentioned this issue Aug 12, 2014
Closed
mikemccand added a commit that referenced this issue Aug 12, 2014
@mikemccand
Java client API: CreateIndexRequestBuilder.addMapping throws IllegalS…
7fa8a0a 
…tateException if you add same type more than once

Previously, it would silently overwrite the previous mapping, which was trappy.

Closes #7231

Closes #7243
mikemccand added a commit that referenced this issue Sep 8, 2014
@mikemccand @areek
Java client API: CreateIndexRequestBuilder.addMapping throws IllegalS…
dec2997 
…tateException if you add same type more than once

Previously, it would silently overwrite the previous mapping, which was trappy.

Closes #7231

Closes #7243
@clintongormley clintongormley changed the title Java client api: CreateIndexRequestBuilder.addMapping should throw exc if that type already has a mapping Java API: CreateIndexRequestBuilder.addMapping should throw exc if that type already has a mapping Sep 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikemccand mikemccand

Labels
>enhancement v1.4.0.Beta1 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
1 participant
@mikemccand