Fix explanation streaming #7257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Explanation explanation = new Explanation(value, description); | ||
|
|
||
| Explanation explanation; | ||
| if (in.getVersion().onOrAfter(org.elasticsearch.Version.V_1_4_0)) { |
There was a problem hiding this comment.
I think you can join the next conditional up to here with && in.readBoolean(), then have just one else condition?
|
I left a couple comments. Looks fine overall. |
Complex explanations were always read as Explanations. Depending on if the response was streamed or not the explanation was therefore generated by a ComplexExplanation or by a regular Explanation.
brwe
force-pushed
the
fix-explanation-streaming
branch
from
0bd1654
to
5a82dd9
Compare
|
Thanks for the comments! Added commits. |
| @@ -320,7 +320,7 @@ public static ValueAndBoost parseCreateFieldForString(ParseContext context, Stri | |||
| if (token == XContentParser.Token.FIELD_NAME) { | |||
| currentFieldName = parser.currentName(); | |||
| } else { | |||
| if ("value".equals(currentFieldName) || "_value".equals(currentFieldName)) { | |||
| if ("value.j.java".equals(currentFieldName) || "_value".equals(currentFieldName)) { | |||
There was a problem hiding this comment.
definitely not! glad you spotted it...
|
LGTM. One oddity in the diff I left a note about. |
|
Removed the oddity. |
|
+1 to commit. |
brwe
added a commit
that referenced
this pull request
Aug 27, 2014
Complex explanations were always read as Explanations. Depending on if the response was streamed or not the explanation was therefore generated by a ComplexExplanation or by a regular Explanation. closes #7257
brwe
added a commit
that referenced
this pull request
Sep 8, 2014
Complex explanations were always read as Explanations. Depending on if the response was streamed or not the explanation was therefore generated by a ComplexExplanation or by a regular Explanation. closes #7257
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complex explanations were always read as Explanations. Depending
on if the response was streamed or not the explanation was
therefore generated by a ComplexExplanation or by a regular
Explanation.