Use preference("_local") on get calls. #7477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -376,11 +378,12 @@ public GetResponse queryScriptIndex(Client client, String scriptLang, String id) | |||
| } | |||
|
|
|||
| public GetResponse queryScriptIndex(Client client, String scriptLang, String id, | |||
| long version, VersionType versionType){ | |||
| long version, VersionType versionType) { | |||
| scriptLang = validateScriptLanguage(scriptLang); | |||
| return client.prepareGet(SCRIPT_INDEX, scriptLang, id) | |||
| .setVersion(version) | |||
| .setVersionType(versionType) | |||
There was a problem hiding this comment.
I think this should have operationThreaded(false) as well?
|
LGTM |
GaelTadh
force-pushed
the
fix/timeoutscriptservice
branch
from
75684f3
to
3c9889d
Compare
This change forces the GetRequest when a script is being loaded from an index
to use preference("_local") and threaded(false) to prevent the script service from
forking for GetRequests.
clintongormley
changed the title
clintongormley
changed the title
clintongormley
changed the title
clintongormley
added
:Core/Infra/Scripting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit sets preference("_local") on get calls to try and prevent
the GetRequest from being forked off.