New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: Allow global test cluster to have configurable settings source #7482
Test: Allow global test cluster to have configurable settings source #7482
Conversation
awesome maybe we can drop that extra ctor in InternalTestCluster too then? |
@@ -123,6 +123,8 @@ | |||
|
|||
private final ESLogger logger = Loggers.getLogger(getClass()); | |||
|
|||
public static SettingsSource CONFIGURABLE_SETTINGS_SOURCE = SettingsSource.EMPTY; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe package private instead of public?
d707469
to
a66df79
Compare
@s1monw I removed the simple unused constructor and left the other two in place. The TribeTests are using it as well and doesnt make too much sense for them to set it explicety in the tests.. this way everything can stay package private |
Left a minor comment, other that that looks great to me! |
Sweet! I'm looking forward to this! |
@javanna yeah! It pretty much closes that issue. |
LGTM |
This allows to reuse the global test cluster with specific configurations, which is useful in plugins.
a66df79
to
3aa72f2
Compare
This allows to reuse the global test cluster with specific configurations,
which is useful in plugins.
Allows to change this in plugin tests like this: