Use ConcurrentHashMap in SCAN search to keep track of the reader states. #7499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should ReaderState.count and done also be made volatile to ensure visibility of the changes? |
|
@martijnvg just told me that they are no modified after having been added to the map, so that is fine. :-) |
|
LGTM |
…tes is accessed by multiple threads during the entire scroll session. Closes elastic#7499 Closes elastic#7478
martijnvg
force-pushed
the
bugs/scan_concurrent_map
branch
from
958d1ac
to
f536956
Compare
clintongormley
changed the title
clintongormley
added
the
:Search/Search
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…tes is accessed by multiple threads during the entire scroll session. Closes elastic#7499 Closes elastic#7478
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…tes is accessed by multiple threads during the entire scroll session. Closes elastic#7499 Closes elastic#7478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #7478