Use SEARCH threadpool for potentially blocking operations
#7624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this change would be a shame to do, since if you execute a 10 shard search, the first 9 will just spawn a thread to add the response to the datastrucutre and return, not really execute anything. I think the actual second / third phase of execution, mainly the reduce of the second query phase, where aggs are being reduced, should be done on the SEARCH thread pool. |
|
@kimchy this makes no sense indeed. the change was pretty naive too though... Yet, I tried to only execute the reduce phases / finish phases in a search thread but this was trickier that I thought. I pushed a working patch with a big nocommit - would love to discuss |
|
I removed the pending no-commits I think it's ready |
|
lgtm |
Reduce Phases can be expensive and some of them like the aggregations reduce phase might even execute a one-off call via an internal client that might cause a deadlock due to execution on the network thread that is needed to handle the one-off call. This commit dispatches the reduce phase to the search threadpool to ensure we don't wait for the current thread to be available. Closes elastic#7623
clintongormley
changed the title
SEARCH threadpool for potentially blocking operationsSEARCH threadpool for potentially blocking operations
clintongormley
added
v1.4.0.Beta
v1.4.0.Beta1
and removed
v1.4.0.Beta1
v1.4.0.Beta
labels
clintongormley
changed the title
SEARCH threadpool for potentially blocking operationsSEARCH threadpool for potentially blocking operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
SearchServiceTransportActionwe useSAMEthreadpool forpotentially blocking / longer running operations this can cause
slowdowns in response / requests processing or even deadlocks. This
commit uses
SEARCHthreadpool for all operations except of freeingcontexts.
Closes #7623