Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent sorting of top_hits fixed #7697

Closed
martijnvg opened this issue Sep 11, 2014 · 0 comments
Closed

Inconsistent sorting of top_hits fixed #7697

martijnvg opened this issue Sep 11, 2014 · 0 comments
Assignees
@martijnvg
Labels
:Analytics/Aggregations Aggregations >bug v1.3.3 v1.4.0.Beta1 v2.0.0-beta1

Comments

@martijnvg
Copy link
Member

In the reduce logic of the top_hits aggregation if the first shard result to process contained has no results then the merging of all the shard results can go wrong resulting in an incorrect sorted hits.

This bug can only manifest with a sort other than score.
@martijnvg martijnvg self-assigned this Sep 11, 2014
martijnvg added a commit that referenced this issue Sep 11, 2014
@martijnvg
Aggregations top_hits: Fixed inconsistent sorting of the hits
d5e1dd6 
In the reduce logic of the top_hits aggregation if the first shard result to process contained has no results then the merging of all the shard results can go wrong resulting in an incorrect sorted hits.
This bug can only manifest with a sort other than score.

Closes #7697
martijnvg added a commit that referenced this issue Sep 11, 2014
@martijnvg
Aggregations top_hits: Fixed inconsistent sorting of the hits
4c30fb3 
In the reduce logic of the top_hits aggregation if the first shard result to process contained has no results then the merging of all the shard results can go wrong resulting in an incorrect sorted hits.
This bug can only manifest with a sort other than score.

Closes #7697
@clintongormley clintongormley changed the title Aggregations top_hits: Inconsistent sorting of the hits Aggregations: Inconsistent sorting of top_hits fixed Sep 26, 2014
@clintongormley clintongormley changed the title Aggregations: Inconsistent sorting of top_hits fixed Inconsistent sorting of top_hits fixed Jun 7, 2015
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@martijnvg
Aggregations top_hits: Fixed inconsistent sorting of the hits
370ced2 
In the reduce logic of the top_hits aggregation if the first shard result to process contained has no results then the merging of all the shard results can go wrong resulting in an incorrect sorted hits.
This bug can only manifest with a sort other than score.

Closes elastic#7697
@colings86 colings86 added :Analytics/Aggregations Aggregations and removed :Analytics/Aggregations Aggregations labels Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martijnvg martijnvg

Labels
:Analytics/Aggregations Aggregations >bug v1.3.3 v1.4.0.Beta1 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clintongormley @colings86 @martijnvg