Write translog opSize twice #7735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new `greedyRead` method that will read the operation sizes, then consume that many bytes in the stream, validating the checksum without transforming the bytes into a `Translog.Operation`. If the bytes are not corrupt they are read into an operation and returned. This new `greedyRead` method is used when reading translogs from disk, where they may have corrupted sizes that can cause OOMEs Adds a new test with a translog with a corrupted opSize and removes the `@AwaitsFix` from the testTranslogCorruption in `AbstractSimpleTranslogTests`.
| public Translog.Operation greedyRead(StreamInput in) throws IOException { | ||
| int opSize = readAndVerifyOpSize(in); | ||
|
|
||
| byte[] bytes = new byte[opSize]; |
There was a problem hiding this comment.
maybe we can use ByteUtils.readIntLE(bytes, opsize-4) here?
There was a problem hiding this comment.
Oh cool, didn't know about that method, I'll do that.
There was a problem hiding this comment.
Actually, looking at it now, StreamOutput writes in big endian, so I'll add a .readIntBE(bytes, opsize-4) method
|
Closing this in favor of a bigger change for 1.5 to come. |
clintongormley
changed the title
clintongormley
changed the title
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
greedyReadmethod that will read the operation sizes, thenconsume that many bytes in the stream, validating the checksum without
transforming the bytes into a
Translog.Operation. If the bytes are notcorrupt they are read into an operation and returned.
This new
greedyReadmethod is used when reading translogs from disk,where they may have corrupted sizes that can cause OOMEs
Adds a new test with a translog with a corrupted opSize and removes the
@AwaitsFixfrom the testTranslogCorruption inAbstractSimpleTranslogTests.