Never send requests after transport service is stopped #7862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -191,11 +197,14 @@ public void removeConnectionListener(TransportConnectionListener listener) { | |||
| final long requestId = newRequestId(); | |||
| TimeoutHandler timeoutHandler = null; | |||
| try { | |||
| clientHandlers.put(requestId, new RequestHolder<>(handler, node, action, timeoutHandler)); | |||
| if (started.get() == false) { | |||
There was a problem hiding this comment.
This can cause double exception handling, one on the caller thread and one on the handler (if the transport is closed between the two lines). I think we should rely on the clientHandels (concurrent map) and rather then throw an exception do the same logic we have in the finally clause in doStop - removed the holder from the clientHandlers, if that works out, call the handler with an exception. Makes sense?
|
I think this good to do, I left one comment w.r.t to potentially double error handling. |
|
@bleskes I think you missed the handling in the catch block...I pushed a new commit with some documetnation for that |
|
@s1monw yes, missed it - was folded away. LGTM |
With local transport or any transport that doesn't necessarily send notification if connections are closed we might miss a node disconnection and the request handler hangs forever / until the timeout kicks in. This window only exists during shutdown and is likely unproblematic in practice but tests might run into this problem when local transport is used.
s1monw
force-pushed
the
mark_transport_service_stopped
branch
from
2c5383e
to
a90d7b1
Compare
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With local transport or any transport that doesn't necessarily send
notification if connections are closed we might miss a node
disconnection and the request handler hangs forever / until the timeout
kicks in. This window only exists during shutdown and is likely
unproblematic in practice but tests might run into this problem when
local transport is used.