Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MasterFaultDetection.Listener.notListedOnMaster #7995

Closed
wants to merge 1 commit into from

Conversation

bleskes
Copy link
Contributor

@bleskes bleskes commented Oct 6, 2014

It is never used in practice. We treat it as a master failure (using NodeDoesNotExistOnMasterException).

It is never used in practice. We treat it as a master failure (using NodeDoesNotExistOnMasterException).
@s1monw
Copy link
Contributor

s1monw commented Oct 6, 2014

LGTM

@s1monw s1monw removed the review label Oct 6, 2014
@martijnvg
Copy link
Member

Right, in practice this is redundant. LGTM!

@bleskes bleskes closed this in 99187e5 Oct 6, 2014
bleskes added a commit that referenced this pull request Oct 6, 2014
It is never used in practice. We treat it as a master failure (using NodeDoesNotExistOnMasterException).

Closes #7995
bleskes added a commit that referenced this pull request Oct 6, 2014
It is never used in practice. We treat it as a master failure (using NodeDoesNotExistOnMasterException).

Closes #7995
@bleskes bleskes deleted the remove_ping_not_listed branch October 6, 2014 15:17
@clintongormley clintongormley changed the title Discovery: remove MasterFaultDetection.Listener.notListedOnMaster Discovery: Remove MasterFaultDetection.Listener.notListedOnMaster Nov 3, 2014
@clintongormley clintongormley added the :Distributed/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure label Jun 7, 2015
@clintongormley clintongormley changed the title Discovery: Remove MasterFaultDetection.Listener.notListedOnMaster Remove MasterFaultDetection.Listener.notListedOnMaster Jun 7, 2015
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
It is never used in practice. We treat it as a master failure (using NodeDoesNotExistOnMasterException).

Closes elastic#7995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure >enhancement v1.4.0 v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants