Simplify discovery node initialization if version is unknown #8055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1monw
added
v2.0.0-beta1
v1.5.0
v1.4.0
v1.3.5
>enhancement
review
and removed
v1.3.5
labels
|
LGTM |
Today it's easy to use the wrong version when initializing DiscoveryNode instances. This commit adds javadocs and a utility constant to initialize DiscoveryNode instances if the the remotes node version is unknown. Closes elastic#8051
|
Is this something that could bite existing users who just try to upgrade to 1.4? Should we be highlighting this in the migrating-to-1.4 docs? |
|
to be honest I think this is very expert and a bit over the top for a migration guide? |
clintongormley
changed the title
clintongormley
changed the title
clintongormley
added
the
:Distributed/Discovery-Plugins
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today it's easy to use the wrong version when initializing DiscoveryNode
instances. This commit adds javadocs and a utility constant to
initialize DiscoveryNode instances if the the remotes node version is
unknown.
Closes #8051