Support for when all fields are deprecated #8067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexksikes
added
Awaiting CLA
review
v1.5.0
v2.0.0-beta1
>enhancement
and removed
Awaiting CLA
labels
alexksikes
changed the title
| @@ -29,6 +29,7 @@ | |||
| private final String camelCaseName; | |||
| private final String underscoreName; | |||
| private final String[] deprecatedNames; | |||
| private String replacedWith; | |||
There was a problem hiding this comment.
Should probably be final (hands wrote null, but the brain meant final).
|
Left some notes. LGTM. |
|
LGTM |
alexksikes
changed the title
alexksikes
added a commit
that referenced
this pull request
Oct 24, 2014
alexksikes
added a commit
that referenced
this pull request
Oct 24, 2014
clintongormley
changed the title
clintongormley
changed the title
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.