Only schedule another refresh if refresh_interval is positive
#8087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a refresh was already running when the refresh_interval is dynamically updated down to a non-positive value (0, -1, etc.), then it's was possible for the refresh thread to go into while (true) refresh() loop. Closes elastic#8085
|
LGTM |
|
@mikemccand maybe put a comment on the future.cancle why we don't pass true :) |
clintongormley
changed the title
refresh_interval is positive
clintongormley
changed the title
refresh_interval is positiverefresh_interval is positive
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
If refresh was already running when the refresh_interval is dynamically disabled (set to a non-positive value like 0, -1, etc.), then it's possible for the refresh thread to go into while (true) refresh() loop. Closes elastic#8085 Closes elastic#8087
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
If refresh was already running when the refresh_interval is dynamically disabled (set to a non-positive value like 0, -1, etc.), then it's possible for the refresh thread to go into while (true) refresh() loop. Closes elastic#8085 Closes elastic#8087
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a EngingRefresher.run was already running when the refresh_interval is
dynamically updated down to a non-positive value (0, -1, etc.), then
it's was possible for the refresh thread to go into while (true)
refresh() loop.
Closes #8085