Allow setting individual breakers to "noop" breakers #8135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // execute a search that loads field data (sorting on the "test" field) | ||
| // again, this time it should NOT trip the breaker | ||
| client.prepareSearch("cb-test").setSource("{\"sort\": \"test\",\"query\":{\"match_all\":{}}}"); |
There was a problem hiding this comment.
why not use the typed API for it?
|
few minor comments (they apply to other parts of the code). Can we also change |
|
@kimchy addressed your feedback and marked this as breaking. |
|
Actually, since there was no separate CircuitBreakerService implementations in 1.3, this isn't breaking! :) |
|
LGTM, would love someone to have another look at the tests |
| private String randomRidiculouslySmallLimit() { | ||
| // 3 different ways to say 100 bytes | ||
| return randomFrom(Arrays.asList("100b", "100")); | ||
| //, (10000. / JvmInfo.jvmInfo().getMem().getHeapMax().bytes()) + "%")); // this is prone to rounding errors and will fail if JVM memory changes! | ||
| //, (10000. / JvmInfo.jvmInfo().getMem().getHeapMax().bytes()) + "%")); // this is prone to rounding errors and will fail if JVM memory changes! |
There was a problem hiding this comment.
Can we remove this line if it is not needed? At a glance it just looks like a broken test that was "simplified".
|
I left some comments on the tests, all minor. LGTM. |
dakrone
force-pushed
the
add-noop-breakers
branch
2 times, most recently
from
4706af5
to
1c4d07c
Compare
This adds a NoopCircuitBreaker, and then adds the settings `indices.breaker.fielddata.type` and `indices.breaker.request.type`, which can be set to "noop" in order to use a breaker that will never break, and incurs no overhead during computation. This also refactors the tests for the CircuitBreakerService to use @before and @after functions as well as adding settings in ElasticsearchIntegrationTest to occasionally use NOOP breakers for all tests.
clintongormley
changed the title
clintongormley
added
the
:Core/Infra/Circuit Breakers
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a NoopCircuitBreaker, and then adds the dynamic settings
indices.breaker.fielddata.typeandindices.breaker.request.type,which can be set to "noop" in order to use a breaker that will never
break, and incurs no overhead during computation.
This also refactors the tests for the CircuitBreakerService to use
@before and @after functions as well as adding settings in
ElasticsearchIntegrationTest to occasionally use NOOP breakers for all
tests.