Fix CompletionFieldMapper to correctly parse weight #8197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -119,8 +119,9 @@ The following parameters are supported: | |||
| might not yield any results, if `input` and `output` differ strongly). | |||
|
|
|||
| `weight`:: | |||
| A positive integer, which defines a weight and allows you to | |||
| rank your suggestions. This field is optional. | |||
| A positive integer or a string representing a positive integer, | |||
There was a problem hiding this comment.
Maybe use "containing" instead of "representing"?
|
I left some comments. The main thing is I would simplify by separating the string/number case, since they really are different other than range checking of the value. |
|
@rjernst Thanks for the feedback, I have updated the PR accordingly. |
| } catch (NumberFormatException e) { | ||
| throw new ElasticsearchIllegalArgumentException("Weight must be a string representing a numeric value, but was [" + parser.text() + "]"); | ||
| } | ||
| weight = weightValue.longValue(); // always parse a long to make sure we don't get the overflow |
There was a problem hiding this comment.
I think just "overflow" not "the overflow"?
|
LGTM, just one more minor comment. |
|
@rjernst Thanks! |
|
@areek you want to get this merged in? |
…ight - Allows weight to be defined as a string representation of a positive integer closes elastic#8090
clintongormley
added
the
:Search/Suggesters
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows weight to be defined as a string representation of a positive integer
closes #8090