Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concurrent calls to refresh might result in "dangling" searchers #823

Closed
kimchy opened this issue Apr 1, 2011 · 1 comment
Closed

Concurrent calls to refresh might result in "dangling" searchers #823

kimchy opened this issue Apr 1, 2011 · 1 comment
Labels
>bug v0.16.0
Milestone
Ignore

Comments

@kimchy
Copy link
Member

kimchy commented Apr 1, 2011

Concurrent calls to refresh might result in "dangling" searchers
@kimchy
Copy link
Member Author

kimchy commented Apr 1, 2011

Concurrent calls to refresh might result in "dangling" searchers, closed by db1dcad.

@kimchy kimchy closed this as completed Apr 1, 2011
williamrandolph pushed a commit to williamrandolph/elasticsearch that referenced this issue Jun 4, 2020
@jaymode @jbaiera
fix memory leak caused by re-wrapping DelegatedProtocol (elastic#823)
35ecfee 
When SSL is used to communicate with elasticsearch, we replace the Protocol for
`https` with a custom protocol that uses a custom created SSLSocketFactory. The
DelegatedProtocol we create wraps the existing protocol, which is fine if we only
wrap a single time. However if the http transport is instantiated multiple times,
the protocol that is wrapped will be the DelegatedProtocol that we created previously
and this causes the existing SSLSocketFactory to be retained indefinitely.

This change adds a check to see if the existing Protocol is a DelegatedProtocol and
if so the original Protocol is retrieved so that we do not retain a reference to the
DelegatedProtocol and its SSLSocketFactory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug v0.16.0
Projects
None yet
Milestone
Ignore
Development

No branches or pull requests
1 participant
@kimchy