Don't eagerly load NestedDocsFilter in bitset filter cache, because it is never used. #8414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it is never used, should we remove it entirely? |
|
@jpountz Makes sense. I updated the PR and remove it. |
|
LGTM |
…agerly load it in bitset filter cache. Closes elastic#8414
martijnvg
force-pushed
the
bugs/bitset_filter_cache_redundant_filter
branch
from
fc3b466
to
696beb6
Compare
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Nov 9, 2014
…agerly load it in bitset filter cache. Closes elastic#8414
martijnvg
added a commit
that referenced
this pull request
Nov 9, 2014
…agerly load it in bitset filter cache. Closes #8414
clintongormley
added
:Cache
and removed
:Core/Infra/Core
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…agerly load it in bitset filter cache. Closes elastic#8414
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #8394