Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geo: incorrect neighbours computation in GeoHashUtils #8526

Closed
clement-tourriere opened this issue Nov 18, 2014 · 0 comments
Closed

Geo: incorrect neighbours computation in GeoHashUtils #8526

clement-tourriere opened this issue Nov 18, 2014 · 0 comments
Assignees
@nknize
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug

Comments

@clement-tourriere
Copy link

GeoHashUtils.neighbor produces bad neighbours for even level geohash (when geohash length is even).

For instance :

For geohash u09tv :

http://geohash.gofreerange.com/ (this geohash is in Paris, France).

Real neighbours for this geohash are [u09wh, u09wj, u09wn, u09tu, u09ty, u09ts, u09tt, u09tw]

GeoHashUtils.neigbors returns [u09qh, u09wj, u09yn, u09mu, u09vy, u09ks, u09st, u09uw]
@clintongormley clintongormley added >bug :Analytics/Geo Indexing, search aggregations of geo points and shapes labels Nov 18, 2014
clement-tourriere pushed a commit to clement-tourriere/elasticsearch that referenced this issue Nov 18, 2014
Fix for geohash neighbors when geohash length is even.
6ed0c07 
We don't have to set XLimit and YLimit depending on the level (even or odd), since semantics of x and y are already swapped on each level.
XLimit is always 7 and YLimit is always 3.

Close elastic#8526
@clement-tourriere clement-tourriere mentioned this issue Nov 18, 2014
Closed
nknize pushed a commit that referenced this issue Nov 25, 2014
@nknize
Fix for geohash neighbors when geohash length is even.
7a7448d 
We don't have to set XLimit and YLimit depending on the level (even or odd), since semantics of x and y are already swapped on each level.
XLimit is always 7 and YLimit is always 3.

Close #8526
@nknize nknize closed this as completed in 15db5b9 Nov 25, 2014
nknize pushed a commit that referenced this issue Nov 25, 2014
@nknize
Fix for geohash neighbors when geohash length is even.
26dc7d8 
We don't have to set XLimit and YLimit depending on the level (even or odd), since semantics of x and y are already swapped on each level.
XLimit is always 7 and YLimit is always 3.

Close #8526
nknize pushed a commit that referenced this issue Nov 25, 2014
@nknize
Fix for geohash neighbors when geohash length is even.
37b603e 
We don't have to set XLimit and YLimit depending on the level (even or odd), since semantics of x and y are already swapped on each level.
XLimit is always 7 and YLimit is always 3.

Close #8526
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@nknize
Fix for geohash neighbors when geohash length is even.
1779dde 
We don't have to set XLimit and YLimit depending on the level (even or odd), since semantics of x and y are already swapped on each level.
XLimit is always 7 and YLimit is always 3.

Close elastic#8526
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@nknize
Fix for geohash neighbors when geohash length is even.
6e8bc6f 
We don't have to set XLimit and YLimit depending on the level (even or odd), since semantics of x and y are already swapped on each level.
XLimit is always 7 and YLimit is always 3.

Close elastic#8526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nknize nknize

Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for geohash neighbors when geohash length is even. clement-tourriere/elasticsearch
3 participants
@clintongormley @nknize @clement-tourriere