Fix for geohash neighbors when geohash length is even. #8529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have to set XLimit and YLimit depending on the level (even or odd), since semantics of x and y are already swapped on each level. XLimit is always 7 and YLimit is always 3. Close elastic#8526
|
@nknize can you take a look at this? |
|
This is a correct and simple fix to a legit bug. As the comment mentions, x/y semantics were already swapped on each geohash level. xLimit and yLimit were reversing the semantics and the unit tests did not catch this boundary condition. I wrote an additional test case to cover the odd and even boundary condition. |
nknize
added
v1.4.0
>bug
:Analytics/Geo
|
@nknize in that case you want to rebase and merge it in to 1.3, 1.4, 1.x and master please? |
|
@clement-tourriere proposed pr merged at request of @clintongormley |
clintongormley
added
v1.3.6
v1.4.1
v1.5.0
v2.0.0-beta1
and removed
v1.4.0
v1.3.0
labels
clintongormley
changed the title
clement-tourriere
pushed a commit
to opendatasoft/elasticsearch-aggregation-geoclustering
that referenced
this pull request
Nov 28, 2014
Use internal GeoHash neighbours computation, fixed by elastic/elasticsearch#8529
clement-tourriere
pushed a commit
to opendatasoft/elasticsearch-aggregation-geoclustering
that referenced
this pull request
Nov 28, 2014
Use internal GeoHash neighbours computation, fixed by elastic/elasticsearch#8529
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have to set XLimit and YLimit depending on the level (even or odd), since semantics of x and y are already swapped on each level.
XLimit is always 7 and YLimit is always 3.
Close #8526