Override write(byte[] b, int off, int len) in FilterOutputStream for better performance

[s1monw]

Closes #8748

[rmuir]

+1, this is a horrible trap. It has a real impact on write performance. Lucene tests got like 8x slower because of one of these that was just being used to do something on close()

[s1monw]

thx for the review @rmuir

[agallou]

Thanks for the fix.

We were using the 1.4.1 version and the snapshot took 5 hours (for 8.52Gi and 1 801 986 docs).
The same snapshot in version 1.4.2 now takes less than one minute.

Snapshot in version 1.4.1 :

{
    "snapshot" : "bkp_20150122214749",
    "indices" : [ "livre.20150122211008", "editeur.20150122211008", "auteur.20150122211008", "fournisseur.20150122211008" ],
    "state" : "SUCCESS",
    "start_time" : "2015-01-22T20:47:49.941Z",
    "start_time_in_millis" : 1421959669941,
    "end_time" : "2015-01-23T01:52:00.983Z",
    "end_time_in_millis" : 1421977920983,
    "duration_in_millis" : 18251042,
    "failures" : [ ],
    "shards" : {
      "total" : 20,
      "failed" : 0,
      "successful" : 20
    }
}

Snapshot in version 1.4.2 :

{
    "snapshot" : "bkp_20150126220702",
    "indices" : [ "livre.20150126002727", "editeur.20150126002727", "fournisseur.20150126002727", "auteur.20150126002727" ],
    "state" : "SUCCESS",
    "start_time" : "2015-01-26T21:07:02.522Z",
    "start_time_in_millis" : 1422306422522,
    "end_time" : "2015-01-26T21:07:42.867Z",
    "end_time_in_millis" : 1422306462867,
    "duration_in_millis" : 40345,
    "failures" : [ ],
    "shards" : {
      "total" : 20,
      "failed" : 0,
      "successful" : 20
    }
}

[clintongormley]

awesome - thanks for the feedback @agallou