Hard wire utf-8 encoding, so unicode filenames work #8847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Shall we also add the same to the pom so tests will run with the same encoding? |
|
I think tests should be handled differently and separately, there is more involved there. For example, we can't assume this default for things like client code and so on. |
|
@rmuir can you get this in? |
rmuir
added a commit
that referenced
this pull request
Dec 15, 2014
Sets -Dfile.encoding=UTF-8 by default. Closes #8847
rmuir
added a commit
that referenced
this pull request
Dec 15, 2014
Sets -Dfile.encoding=UTF-8 by default. Closes #8847
|
I removed 1.3.x since it is structured differently (e.g. no elasticsearch.in.bat) |
clintongormley
changed the title
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Sets -Dfile.encoding=UTF-8 by default. Closes elastic#8847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today e.g unicode index names are allowed, but you will get no error if a machine is misconfigured. Because they are allowed, we should explicitly set UTF-8 encoding by default.
For a server-side app, this is really a good flag to pass to the JVM anyway. it will dodge bugs in third party libraries and so on.