Post collection the children agg should also invoke that phase on its wrapped child aggs. #9291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
review
v1.4.3
v1.5.0
v2.0.0-beta1
>bug
:Analytics/Aggregations
|
LGTM. |
…he buckets on the parent level to the child level and because of that it needs to invoke the post collection of its nested aggs. Closes elastic#9271
martijnvg
force-pushed
the
bugs/children-agg-should-invoke-postCollection
branch
from
6f76d17
to
79374c1
Compare
clintongormley
changed the title
clintongormley
added
:Parent/Child
and removed
:Analytics/Aggregations
clintongormley
changed the title
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also includes changes for the GlobalOrdinalsStringTermsAggregator.java file, but that is just indentation fix.
PR for #9271