ClusterInfoService should wipe local cache upon unknown exceptions #9449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eptions The InternalClusterInfoService reaches out to the nodes to get information about their disk usage and shard store size. Upon a node level error we currently remove the node info from the local cache. We should also clear the cache when we run into an error on the action level (excluding any info from all nodes). This also adds settings for the timeout used when waiting for nodes.
| @@ -140,6 +151,11 @@ public void onMaster() { | |||
| } | |||
| } | |||
|
|
|||
| // called from tests as well | |||
| void updateOnce() { | |||
There was a problem hiding this comment.
This needs actual javadocs, just looking at it is doesn't tell that it executes the job with rescheduling false (you have to read the constructor argument for ClusterInfoUpdateJob to see that
| for (DiscoveryNode node : internalTestCluster.clusterService().state().getNodes()) { | ||
| mockTransportService.addDelegate(node, new MockTransportService.DelegateTransport(mockTransportService.original()) { | ||
| @Override | ||
| public void sendRequest(DiscoveryNode node, long requestId, String action, TransportRequest request, TransportRequestOptions options) throws IOException, TransportException { |
There was a problem hiding this comment.
Dude! Linebreaks! Strive for 80 columns! (or at least 100 or 120) :D
|
@dakrone pushed another commit. thx |
|
LGTM |
bleskes
added a commit
that referenced
this pull request
Jan 27, 2015
…eptions The InternalClusterInfoService reaches out to the nodes to get information about their disk usage and shard store size. Upon a node level error we currently remove the node info from the local cache. We should also clear the cache when we run into an error on the action level (excluding any info from all nodes). This also adds settings for the timeout used when waiting for nodes. Closes #9449
bleskes
added a commit
that referenced
this pull request
Jan 27, 2015
…eptions The InternalClusterInfoService reaches out to the nodes to get information about their disk usage and shard store size. Upon a node level error we currently remove the node info from the local cache. We should also clear the cache when we run into an error on the action level (excluding any info from all nodes). This also adds settings for the timeout used when waiting for nodes. Closes #9449
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…eptions The InternalClusterInfoService reaches out to the nodes to get information about their disk usage and shard store size. Upon a node level error we currently remove the node info from the local cache. We should also clear the cache when we run into an error on the action level (excluding any info from all nodes). This also adds settings for the timeout used when waiting for nodes. Closes elastic#9449
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The InternalClusterInfoService reaches out to the nodes to get information about their disk usage and shard store size. Upon a node level error we currently remove the node info from the local cache. We should also clear the cache when we run into an error on the action level (excluding any info from all nodes).
This also adds settings for the timeout used when waiting for nodes.