Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make script.groovy.sandbox.method_blacklist_patch truly append-only #9473

Merged
merged 1 commit into from Jan 29, 2015

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Jan 28, 2015

Additionally, this setting can be specified in elasticsearch.yml if
desired, to pre-populate the list of methods to be added to the default
blacklist.

When making a change to this setting dynamically, the entire blacklist
is logged as well.

@rjernst
Copy link
Member

rjernst commented Jan 28, 2015

LGTM.

@kimchy
Copy link
Member

kimchy commented Jan 29, 2015

LGTM

Additionally, this setting can be specified in elasticsearch.yml if
desired, to pre-populate the list of methods to be added to the default
blacklist.

When making a change to this setting dynamically, the entire blacklist
is logged as well.
@dakrone dakrone merged commit 86e52c3 into elastic:master Jan 29, 2015
@clintongormley clintongormley changed the title Make script.groovy.sandbox.method_blacklist_patch truly append-only Scripting: Make script.groovy.sandbox.method_blacklist_patch truly append-only Feb 10, 2015
@clintongormley clintongormley added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache and removed review labels Mar 19, 2015
@dakrone dakrone deleted the groovy-blacklist-only-add branch April 6, 2015 17:50
@clintongormley clintongormley changed the title Scripting: Make script.groovy.sandbox.method_blacklist_patch truly append-only Make script.groovy.sandbox.method_blacklist_patch truly append-only Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants