Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java API: Move all request builders to org.elasticsearch.action... from org.elasticsearch.client.action #1611

Closed
kimchy opened this issue Jan 15, 2012 · 2 comments
Closed

Java API: Move all request builders to org.elasticsearch.action... from org.elasticsearch.client.action #1611

kimchy opened this issue Jan 15, 2012 · 2 comments
Labels
>breaking >enhancement v0.19.0.RC1

Comments

@kimchy
Copy link
Member

kimchy commented Jan 15, 2012

This is part of the effort to simplify action (API) development, and plugins allowing for custom actions and have them exposed as part of the Client interface. Sadly, it breaks backward comp., though its a simple change. Some plugins will require to be modified (like the couchdb one).
@kimchy kimchy closed this as completed in 8ee6ee0 Jan 15, 2012
@dadoonet
Copy link
Member

Hi Shay,

Why don't you keep the old class in org.elasticsearch.client.action package, use inheritance from package org.elasticsearch.action and just mark the old class as deprecated ?
It would be easier to migrate all plugins smoothly.

Am I wrong ?

@dadoonet
Copy link
Member

BTW, I created pull request elastic/elasticsearch-river-couchdb#9 for couchDb plugin

@dadoonet dadoonet mentioned this issue Oct 18, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>breaking >enhancement v0.19.0.RC1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimchy @dadoonet