Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: Allow for plugins to implement onModule method that will be automatically injected with the relevant module type #1613

Closed
kimchy opened this issue Jan 15, 2012 · 1 comment
Closed

Plugins: Allow for plugins to implement onModule method that will be automatically injected with the relevant module type #1613

kimchy opened this issue Jan 15, 2012 · 1 comment
Labels
>feature v0.19.0.RC1

Comments

@kimchy
Copy link
Member

kimchy commented Jan 15, 2012

Currently, to add custom injections to different modules, plugins need to implement processModule method and then do instanceof checks.

Allow for plugins to implement an onModule method that will be injected automatically with the parameter module type. For example: onModule(AnalyzerModule module) {...}.
@kimchy kimchy closed this as completed in 1d35e27 Jan 15, 2012
@medcl
Copy link
Contributor

medcl commented Mar 6, 2012

+++

sDaniel pushed a commit to sDaniel/elasticsearch-river-ldap that referenced this issue Jan 14, 2015
processModule > onModule (ES API updated)
50f89da 
elastic/elasticsearch#1613
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>feature v0.19.0.RC1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimchy @medcl