Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport/Http: Remove explicit setting of send/receive buffer, and improve netty receive buffer predictor #2124

Closed
kimchy opened this issue Jul 30, 2012 · 0 comments

Comments

@kimchy
Copy link
Member

kimchy commented Jul 30, 2012

First, don't explicitly set the send / receive buffers of the sockets, i.e. remove the default values for network.tcp.send_buffer_size and network.tcp.receive_buffer_size and let the OS control that unless explicitly set.

Second, netty uses a "user space" receive buffer, with adaptive size from 1k to 64k. Allow to control that using transport.netty.receive_predictor_size (for transport) and http.netty.receive_predictor_size (for http) (min / max can be set instead of size, though fixed size is preferable). Also, change that default value to 512k, as 64k is too small.

@kimchy kimchy closed this as completed in 4eb85bb Jul 30, 2012
kimchy added a commit that referenced this issue Jul 30, 2012
…mprove netty receive buffer predictor, closes #2124.
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant