Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MinimumNumberShouldMatch inconcistency #2194

Closed
s1monw opened this issue Aug 22, 2012 · 1 comment
Closed

MinimumNumberShouldMatch inconcistency #2194

s1monw opened this issue Aug 22, 2012 · 1 comment
Labels
>enhancement v0.19.9 v0.20.0.RC1

Comments

@s1monw
Copy link
Contributor

s1monw commented Aug 22, 2012

I ran into this while using the API - the same parameter is named differently throughout the API. We currently have

  • "minimum_number_should_match" and the api method minimumNumberShouldMatch(string)
  • "minimum_should_match" and the api method minimumShouldMatch(String)
  • "minimum_match" and the api method minimumMatch(int)

yet the last one has a slightly different semantic since it is more explicit, I still want to discuss to make this consistent since they all have the same purpose and having 3 different names is confusing. I suggest do use the "minimumShouldMatch" version consistently and deprecate the other methods in 0.19 we certainly need support minimum_number_should_match as JSON keys for compatibility

comments welcome
@kimchy
Copy link
Member

kimchy commented Aug 22, 2012

I agree, even more, for example, we can add support for the custom syntax in the bool query, which we don't currently.

@kimchy kimchy closed this as completed in 14c11a9 Aug 22, 2012
kimchy added a commit that referenced this issue Aug 22, 2012
@kimchy
MinimumNumberShouldMatch inconcistency, closes #2194
6163539 
Streamline the use of minimum should match to all relevant queries to accept `minimum_should_match`, and allow all relevant queries to accept the advanced "string" based config
martijnvg pushed a commit to martijnvg/elasticsearch that referenced this issue Aug 27, 2012
@kimchy @martijnvg
MinimumNumberShouldMatch inconcistency, closes elastic#2194
3b3e3cc 
Streamline the use of minimum should match to all relevant queries to accept `minimum_should_match`, and allow all relevant queries to accept the advanced "string" based config
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@kimchy
MinimumNumberShouldMatch inconcistency, closes elastic#2194
36321ad 
Streamline the use of minimum should match to all relevant queries to accept `minimum_should_match`, and allow all relevant queries to accept the advanced "string" based config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement v0.19.9 v0.20.0.RC1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimchy @s1monw