Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indices filter parsed for indices to which it should not apply #2416

Closed
clintongormley opened this issue Nov 16, 2012 · 1 comment
Closed

Indices filter parsed for indices to which it should not apply #2416

clintongormley opened this issue Nov 16, 2012 · 1 comment
Assignees
@javanna
Labels
>bug v0.90.8 v1.0.0.Beta2

Comments

@clintongormley
Copy link

A used in the forum is trying to apply a nested filter to just one index, while querying more than one index, some of which don't have the nested mapping.

The query is complaining about a missing nested mapping, but on the indices to which the query should not apply.

Create two indices: test_1 with a nested mapping, and test_2 without a nested mapping:

curl -XPUT 'http://127.0.0.1:9200/test_1/?pretty=1'  -d '
{
   "mappings" : {
      "foo" : {
         "properties" : {
            "authors" : {
               "type" : "nested",
               "properties" : {
                  "name" : {
                     "type" : "string"
                  }
               }
            },
            "title" : {
               "type" : "string"
            }
         }
      }
   }
}
'

curl -XPUT 'http://127.0.0.1:9200/test_2/?pretty=1'  -d '
{
   "mappings" : {
      "bar" : {
         "properties" : {
            "title" : {
               "type" : "string"
            }
         }
      }
   }
}
'

Index some data:

curl -XPOST 'http://127.0.0.1:9200/test_1/foo?pretty=1'  -d '
{
   "author" : {
      "name" : "john smith"
   },
   "title" : "test 1 doc"
}
'

curl -XPOST 'http://127.0.0.1:9200/test_2/bar?pretty=1'  -d '
{
   "title" : "test 2 doc"
}
'

Query test_1 and test_2 but limit the nested filter to just test_1:

curl -XGET 'http://127.0.0.1:9200/test_1%2Ctest_2/_search?pretty=1'  -d '
{
   "query" : {
      "filtered" : {
         "filter" : {
            "indices" : {
               "no_match_filter" : "none",
               "filter" : {
                  "nested" : {
                     "filter" : {
                        "term" : {
                           "author.name" : "john"
                        }
                     },
                     "path" : "author"
                  }
               },
               "indices" : [
                  "test_1"
               ]
            }
         },
         "query" : {
            "match" : {
               "title" : "test"
            }
         }
      }
   }
}
'

Throws this error:

SearchPhaseExecutionException[Failed to execute phase [query], total failure; shardFailures {[Yit05d94RgiUwMg9vzMOgw][test_1][1]: SearchParseException[[test_1][1]: from[-1],size[-1]: Parse Failure [Failed to parse source [{
   "query" : {
      "filtered" : {
         "filter" : {
            "indices" : {
               "no_match_filter" : "none",
               "filter" : {
                  "nested" : {
                     "filter" : {
                        "term" : {
                           "author.name" : "john"
                        }
                     },
                     "path" : "author"
                  }
               },
               "indices" : [
                  "test_1"
               ]
            }
         },
         "query" : {
            "match" : {
               "title" : "test"
            }
         }
      }
   }
}
@andrewclegg
Copy link

I've seen this behaviour too. I have a horrible feeling that it's causing a whole pile of extra work on our cluster. If someone's running a search that only covers two weeks of data, we really don't want to start dozens of extra threads for the rest of the year, even if ultimately they return no data.

@ghost ghost assigned javanna Sep 12, 2013
@ofavre ofavre mentioned this issue Nov 6, 2013
Closed
ofavre pushed a commit to yakaz/elasticsearch that referenced this issue Nov 13, 2013
Indices query/filter skip parsing altogether for irrelevant indices - f…
0569a73 
…ix elastic#2416
javanna pushed a commit that referenced this issue Nov 14, 2013
@javanna
Indices query/filter skip parsing altogether for irrelevant indices w…
2b256ac 
…hen possible

Closes #2416
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@javanna
Indices query/filter skip parsing altogether for irrelevant indices w…
c9daa01 
…hen possible

Closes elastic#2416
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javanna javanna

Labels
>bug v0.90.8 v1.0.0.Beta2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Indices query/filter skip parsing altogether for irrelevant indices yakaz/elasticsearch
3 participants
@clintongormley @andrewclegg @javanna