Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

max_score == NaN #263

Closed
clintongormley opened this issue Jul 16, 2010 · 7 comments
Closed

max_score == NaN #263

clintongormley opened this issue Jul 16, 2010 · 7 comments

Comments

@clintongormley
Copy link

Hiya

I was incorrect about NaN being valid JSON. Apparently:

Finite numbers are stringified as if by String(number). NaN and Infinity regardless of sign are represented as the string null.

So for situations when there IS no max_score, I'd suggest using zero instead of null or "NaN"

clint
@kimchy
Copy link
Member

kimchy commented Jul 16, 2010

zero is problematic, since it does not indicate a "not valid" max_score, but maybe with a disclaimer that states that you need to check total hits first?

@clintongormley
Copy link
Author

What would be a "not valid" max_score? You could return null but I can't see why that would be useful.

@kimchy
Copy link
Member

kimchy commented Jul 16, 2010

Thats what I meant, there isn't really a non valid score (especially with custom scoring now) that I can return to indicate the fact that there isn't a score associated with this result.

@kimchy
Copy link
Member

kimchy commented Jul 16, 2010

Going to return a null value for the max_score in such cases, will push shortly.

@kimchy
Copy link
Member

kimchy commented Jul 16, 2010

max_score == NaN, closed by e61dc78.

@clintongormley
Copy link
Author

_score should probably also be null rather than NaN

@kimchy
Copy link
Member

kimchy commented Jul 17, 2010

yea, fixed.

williamrandolph pushed a commit to williamrandolph/elasticsearch that referenced this issue Jun 4, 2020
@costin
[DOC] fix typos + section on setting doc IDs
fc9b3aa 
Fix elastic#263
mindw pushed a commit to mindw/elasticsearch that referenced this issue Sep 5, 2022
Merged in dev/igor/MPC-2803 (pull request elastic#263)
2dca125 
MPC-2803 : adding redis tags


* edit eng-igor.tfvars

* igor tfvars

* igor tfvars

* adding redis tags

* fix


Approved-by: Can Yildiz
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this issue Oct 2, 2023
@danielmitterdorfer
Use Rally's artifact cache cleanup (elastic#263)
7f40bf6 
With this commit we remove night-rally's custom artifact cache cleanup
and instead rely on Rally's mechanism implemented in elastic/rally#998.
We also set the cache duration to two days (instead of the default seven
days) to ensure artifacts are cached for the nightlies but are still
present for quick follow-up investigations without taking up too much
space on disk.

Relates elastic/rally#998
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimchy @clintongormley