Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON object properties are not positional #27

Closed
clintongormley opened this issue Feb 19, 2010 · 3 comments
Closed

JSON object properties are not positional #27

clintongormley opened this issue Feb 19, 2010 · 3 comments
Labels
>bug v0.05.0

Comments

@clintongormley
Copy link

Hiya

It looks like you are parsing JSON as a stream, where position matters, instead of parsing the whole objects before analysing them. For instance, this works:

curl -XGET 'http://127.0.0.2:9200/_all/_search'  -d '
{ query: 
    {
       "filteredQuery" : {
          "query" : {
             "term" : {
                "text" : "foo"
             }
          },
          "filter" : {
             "range" : {
                "num" : {
                   "from" : 10,
                   "to" : 20
                }
             }
          }
       }
   }
}
'

But this fails:
curl -XGET 'http://127.0.0.2:9200/_all/_search' -d '
{ query:
{
"filteredQuery" : {
"filter" : {
"range" : {
"num" : {
"to" : 20,
"from" : 10
}
}
},
"query" : {
"term" : {
"text" : "foo"
}
}
}
}
}
'

A JSON parser should consider these two structures to be identical, which is also the thing that rules out having non-unique property names.

thanks

Clint

(Edited to correct JSON)
@kimchy
Copy link
Member

kimchy commented Feb 19, 2010

In all the places where JSON is handled, location is not relevant. This problem is not actually related to the location of the filter and the query (there is support for placing them where you want) but with the fact the range query did not behaved correctly when used as inner query.

I pushed a fix for it, can you give it a go?

@clintongormley
Copy link
Author

Perfect! that works - thanks

@kimchy
Copy link
Member

kimchy commented Feb 20, 2010

Great, closing.

This was referenced Dec 7, 2014
Closed
Closed
dadoonet added a commit that referenced this issue Jun 5, 2015
@dadoonet
Update to Elasticsearch 0.90.1
09d4c5b 
Works also with Elasticsearch 0.90.0.
Closes #27.
dadoonet added a commit that referenced this issue Jun 5, 2015
@dadoonet
Update to elasticsearch 1.3.0
2c68154 
Closes #27.
(cherry picked from commit 5effcce)
dadoonet added a commit that referenced this issue Jun 5, 2015
@dadoonet
Add integration tests
1066984 
Closes #27.
(cherry picked from commit d43d4df)
johtani added a commit that referenced this issue Jun 5, 2015
@johtani @dadoonet
add ICUNormalizer2CharFilter
f1eae45 
Included ICUNormalizer2Charfilter in Lucene 4.8.0.
Add CharFilterFactory.

Now, char_filter name is "icu_normalizer", however token_filter name is same name.

Closes #27.

(cherry picked from commit 0cbf1b3)
dadoonet added a commit that referenced this issue Jun 5, 2015
@dadoonet
_ is a forbidden character for container (repository)
976448e 
According to [Containers naming guide](http://msdn.microsoft.com/en-us/library/dd135715.aspx):

> A container name must be a valid DNS name, conforming to the following naming rules:
>
> * Container names must start with a letter or number, and can contain only letters, numbers, and the dash (-) character.
> * Every dash (-) character must be immediately preceded and followed by a letter or number; consecutive dashes are not permitted in container names.
> * All letters in a container name must be lowercase.
> * Container names must be from 3 through 63 characters long.

We need to fix the documentation and control that before calling Azure API.
The validation will come with issue #27.

Closes #21.

(cherry picked from commit 6531165)
dadoonet pushed a commit that referenced this issue Jun 5, 2015
@simonmorley @dadoonet
Add multiple zones support
8e8e76f 
Closes #27.
dadoonet added a commit that referenced this issue Jun 5, 2015
@dadoonet
Update to Lucene 4.10.0
6cf79f9 
Closes #27.
dadoonet added a commit that referenced this issue Jun 9, 2015
@dadoonet
Update to Lucene 4.10.0
02809f4 
Closes #27.

(cherry picked from commit 1eb2352)
@donkoink donkoink mentioned this issue Jun 25, 2015
Closed
@makeyang makeyang mentioned this issue Sep 7, 2015
Closed
ywelsch pushed a commit to ywelsch/elasticsearch that referenced this issue Apr 24, 2018
@DaveCTurner
Better log messages (elastic#27)
0965384 
Miscellaneous fixes/clarifications to log messages that arose
in tracking down elastic#26.
rjernst pushed a commit that referenced this issue Apr 24, 2018
@hub-cap
Add comments inadvertently removed during migrate (#27)
edf37ec 
A few files had their first comment removed even though it did not
contain a license. This re-adds those comments.
ClaudioMFreitas pushed a commit to ClaudioMFreitas/elasticsearch-1 that referenced this issue Nov 12, 2019
@jakommo
Merge pull request elastic#27 from electrical/extend_testing
0504309 
Add tests for new feature
henningandersen pushed a commit to henningandersen/elasticsearch that referenced this issue Jun 4, 2020
@cdahlqvist
Fixed path error for create index runner and Kibana parameter source. (…
aa3f097 
…elastic#27)
mindw pushed a commit to mindw/elasticsearch that referenced this issue Sep 5, 2022
Merged in dev/gideon/update_engageli_sanbox_script_2020.12.07 (pull r…
2835164 
…equest elastic#27)

* Add script to update Engageli sandbox

Script uses similar mechanisms to provisioning and boot strapping, e.g.
"packages" are taken from the shared assets bucket

Because media-manager webapp sandbox dir needs to be defined at build time,
only "class" and "staging" will get the new app.

Configuration changes/additions to local.yml are not handled.

Also:

* Add script to share existing engageli AMIs with a (new) account
* Add script to tag multiple repos. Tentatively putting in packer
  dir since it's build related. I'm open to suggestions.
* Workaround for expiring credentials mid build. Added option
  to skip build to immediately copy and share supplied AMI
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this issue Oct 2, 2023
@jimczi
Merge pull request elastic#29 from jimczi/challenges/index_sorting
6ca49ce 
Add index sorting challenges to nightly
Closes elastic#27
@Ewemek Ewemek mentioned this issue Nov 29, 2023
Closed
emilykmarx pushed a commit to emilykmarx/elasticsearch that referenced this issue Dec 26, 2023
@jsvd @jordansissel
adds sniffing option for transport protocol
6860bd6 
Fixes elastic#27
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug v0.05.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimchy @clintongormley