Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interchanged values in field_data stats #2724

Closed
gakhov opened this issue Mar 4, 2013 · 5 comments
Closed

Interchanged values in field_data stats #2724

gakhov opened this issue Mar 4, 2013 · 5 comments
Assignees
@s1monw
Labels
>bug v0.90.0.RC1

Comments

@gakhov
Copy link
Contributor

gakhov commented Mar 4, 2013

In version 0.9.0.Beta1 there is an interchange between field_data.memory_size and field_data.memory_size_in_bytes.

To reproduce:

  1. curl http://localhost:9200/_nodes/_local/stats?pretty=true

Actual result:

        "field_data" : {
          "memory_size" : 257199478,
          "memory_size_in_bytes" : "245.2mb"
        },

Expected result:

        "field_data" : {
          "memory_size" : "245.2mb",
          "memory_size_in_bytes" : 257199478
        },

Here is a pull request: #2725
@gakhov gakhov mentioned this issue Mar 4, 2013
Merged
@ghost ghost assigned s1monw Mar 4, 2013
@s1monw
Copy link
Contributor

s1monw commented Mar 4, 2013

makes perfect sense, thanks!

@s1monw s1monw closed this as completed in dc28151 Mar 4, 2013
@s1monw
Copy link
Contributor

s1monw commented Mar 4, 2013

thanks @gakhov

@kimchy
Copy link
Member

kimchy commented Mar 4, 2013

I am going to change the field_data part to fielddata, though less readable it matches our configuration options that match it...

@gakhov
Copy link
Contributor Author

gakhov commented Mar 5, 2013

good to know ... right now we use that information for monitoring our clusters ... this change will require us to rewrite our monitoring plugins (for munin, for instance) to support 2 versions ... not big deal, but still ...

@kimchy
Copy link
Member

kimchy commented Mar 6, 2013

@gakhov thats why we are still not GA with it, I think its a good change if we want to be consistent across the board with how we name references to the fielddata component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1monw s1monw

Labels
>bug v0.90.0.RC1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kimchy @gakhov @s1monw