Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid usage of new StringReader(String) #3411

Closed
jpountz opened this issue Jul 30, 2013 · 2 comments
Closed

Forbid usage of new StringReader(String) #3411

jpountz opened this issue Jul 30, 2013 · 2 comments
Labels
>enhancement v0.90.3 v1.0.0.Beta1

Comments

@jpountz
Copy link
Contributor

jpountz commented Jul 30, 2013

We have FastStringReader and should ensure it is always used instead of StringReader.
@s1monw
Copy link
Contributor

s1monw commented Jul 30, 2013

pull request looks good to me! go push it

jpountz added a commit that referenced this issue Jul 31, 2013
@jpountz
Forbid usage of StringReader in favor of FastStringReader.
5529a9a 
StringReader is synchronized although input streams should always be consumed
by a single thread at a time. FastStringReader on the other hand is completely
thread unsafe.

Closes #3411
@jpountz
Copy link
Contributor Author

jpountz commented Jul 31, 2013

Pushed. Thanks for the review, Simon.

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@jpountz
Forbid usage of StringReader in favor of FastStringReader.
4dab589 
StringReader is synchronized although input streams should always be consumed
by a single thread at a time. FastStringReader on the other hand is completely
thread unsafe.

Closes elastic#3411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement v0.90.3 v1.0.0.Beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpountz @s1monw