Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject indexing requests which specify a parent, if no parent type is defined #3848

Closed
bleskes opened this issue Oct 8, 2013 · 0 comments
Closed

Reject indexing requests which specify a parent, if no parent type is defined #3848

bleskes opened this issue Oct 8, 2013 · 0 comments
Assignees
@martijnvg
Labels
>breaking >bug v0.90.6 v1.0.0.Beta1

Comments

@bleskes
Copy link
Contributor

bleskes commented Oct 8, 2013

If you submit an indexing request and specify a parent but the mapping doesn't define a parent type, we currently silently ignore the parent value:

curl -XPUT "http://localhost:9200/test/type/1?parent=1" -d'
{
   "field": "value" 
}'

We should reject the request.

The breaking part: Index requests with the parent flag will be rejected if there is no _parent metadata field in the mapping.
@ghost ghost assigned bleskes and martijnvg Oct 8, 2013
@martijnvg martijnvg mentioned this issue Oct 14, 2013
Closed
martijnvg added a commit to martijnvg/elasticsearch that referenced this issue Oct 15, 2013
@martijnvg
Prohibit indexing a document with parent for a type that doesn't have…
30447c1 
… a `_parent` field configured.

Closes elastic#3848
martijnvg added a commit that referenced this issue Oct 15, 2013
@martijnvg
Prohibit indexing a document with parent for a type that doesn't have…
39dafc0 
… a `_parent` field configured and prohibit adding a _parent field to an existing mapping.

Closes #3848
Closes #3849
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@martijnvg
Prohibit indexing a document with parent for a type that doesn't have…
7d22170 
… a `_parent` field configured and prohibit adding a _parent field to an existing mapping.

Closes elastic#3848
Closes elastic#3849
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martijnvg martijnvg

Labels
>breaking >bug v0.90.6 v1.0.0.Beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martijnvg @bleskes