Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thrift definition params is conflict with c#'s keyword, rename to parameters #392

Closed
medcl opened this issue Sep 30, 2010 · 1 comment
Closed

thrift definition params is conflict with c#'s keyword, rename to parameters #392

medcl opened this issue Sep 30, 2010 · 1 comment
Labels
>breaking >enhancement v0.12.0

Comments

@medcl
Copy link
Contributor

medcl commented Sep 30, 2010

in thrift idl elasticsearch.thrift:

struct RestRequest {
1: required Method method,
2: required string uri
3: optional map<string, string> params
4: optional map<string, string> headers
5: optional binary body
}

the params is a keyword in .net,though can hack it with a @before params,maybe is should avoid this.
@kimchy
Copy link
Member

kimchy commented Sep 30, 2010

thrift definition params is conflict with c#'s keyword, rename to parameters, closed by 06c7c4a.

medcl pushed a commit to medcl/elasticsearch that referenced this issue Jul 1, 2011
@kimchy
thrift definition params is conflict with c#'s keyword, rename to `…
06c7c4a 
…parameters`, closes elastic#392.
ClaudioMFreitas pushed a commit to ClaudioMFreitas/elasticsearch-1 that referenced this issue Nov 12, 2019
@Crazybus
Merge pull request elastic#392 from edge-records/master
03a685b 
Parameterize timeout value for ES startup in Debian SysV init scripts
mindw pushed a commit to mindw/elasticsearch that referenced this issue Sep 5, 2022
Merged in dev/can/add-dev2-2022-01-12 (pull request elastic#392)
accd3a8 
Add dev2 stack

* Add dev2 stack

* Remove deprecated var from dev1
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this issue Oct 2, 2023
@ebadyano
Update release charts to fix color scheme (elastic#392)
5d6f97c 
Relates to: elastic/night-rally#386
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>breaking >enhancement v0.12.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimchy @medcl