Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Awareness attributes can't be reset once they are set. #3931

Closed
s1monw opened this issue Oct 17, 2013 · 0 comments · Fixed by #3935
Closed

Awareness attributes can't be reset once they are set. #3931

s1monw opened this issue Oct 17, 2013 · 0 comments · Fixed by #3935
Assignees
@s1monw
Labels
>bug v0.90.6 v1.0.0.Beta1

Comments

@s1monw
Copy link
Contributor

s1monw commented Oct 17, 2013

once you set "cluster.routing.allocation.awareness.attributes" via the API you can't reset it to an empty list which would disable the awareness entirely. This happens since the Settings.getAsArray returns the default if the list is null or empty which essentially prevents an update to an empty list.
@ghost ghost assigned s1monw Oct 17, 2013
@s1monw s1monw mentioned this issue Oct 18, 2013
Merged
@s1monw s1monw closed this as completed in f749db2 Oct 18, 2013
s1monw added a commit that referenced this issue Oct 18, 2013
@s1monw
Allow awareness attributes to be reset via the API
ecc22ed 
Currently we don't allow resetting the awareness
attribute via the API since it requires at least one
non-empty string to update the setting. This commit
allows resetting this using an empty string.

Closes #3931
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@s1monw
Allow awareness attributes to be reset via the API
9876259 
Currently we don't allow resetting the awareness
attribute via the API since it requires at least one
non-empty string to update the setting. This commit
allows resetting this using an empty string.

Closes elastic#3931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1monw s1monw

Labels
>bug v0.90.6 v1.0.0.Beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow awareness attributes to be reset via the API s1monw/elasticsearch
1 participant
@s1monw