Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using JAVA_OPTS might fail in service.bat #4127

Closed
costin opened this issue Nov 8, 2013 · 0 comments
Closed

using JAVA_OPTS might fail in service.bat #4127

costin opened this issue Nov 8, 2013 · 0 comments
Assignees
@costin
Labels
>bug v0.90.7 v1.0.0.Beta2

Comments

@costin
Copy link
Member

costin commented Nov 8, 2013

Relates to #4086
JAVA_OPTS and ES_JAVA_OPTS can trip service.bat if the former contains multiple parameters or/and the former contains parenthesis.
@ghost ghost assigned costin Nov 8, 2013
costin added a commit that referenced this issue Nov 8, 2013
@costin
fix issues with JAVA_OPTS/ES_JAVA_OPTS in service.bat
fb44e9a 
fix handling of non-empty JAVA_OPTS
remove usage of if/else that can be tripped by parenthesis in the variable
fixes #4127
closes #4086
@costin costin closed this as completed in 97bdc8f Nov 8, 2013
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@costin
fix issues with JAVA_OPTS/ES_JAVA_OPTS in service.bat
2ee9dc1 
fix handling of non-empty JAVA_OPTS
remove usage of if/else that can be tripped by parenthesis in the variable
fixes elastic#4127
closes elastic#4086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@costin costin

Labels
>bug v0.90.7 v1.0.0.Beta2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@costin