Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ElasticsearchInterruptedException and handle interrupt state correctly. #4712

Closed
s1monw opened this issue Jan 13, 2014 · 0 comments
Closed

Comments

@s1monw
Copy link
Contributor

s1monw commented Jan 13, 2014

InterruptedExceptions should be handled by either rethrowing or restoring the interrupt state (i.e. calling Thread.currentThread().interrupt()). This is important since the caller of the is method or subequent method calls might also be interested in this exception. If we ignore the interrupt state the caller might be left unaware of the exception and blocks again on a subsequent method.

@ghost ghost assigned s1monw Jan 13, 2014
s1monw added a commit to s1monw/elasticsearch that referenced this issue Jan 13, 2014
correctly.

InterruptedExceptions should be handled by either rethrowing or
restoring the interrupt state (i.e. calling
`Thread.currentThread().interrupt()`). This is important since the
caller of the is method or subequent method calls might also be
interested in this exception. If we ignore the interrupt state the
caller might be left unaware of the exception and blocks again on
a subsequent method.

Closes elastic#4712
@s1monw s1monw closed this as completed in a1efa1f Jan 13, 2014
brusic pushed a commit to brusic/elasticsearch that referenced this issue Jan 19, 2014
correctly.

InterruptedExceptions should be handled by either rethrowing or
restoring the interrupt state (i.e. calling
`Thread.currentThread().interrupt()`). This is important since the
caller of the is method or subequent method calls might also be
interested in this exception. If we ignore the interrupt state the
caller might be left unaware of the exception and blocks again on
a subsequent method.

Closes elastic#4712
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant