Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot API : Why is "include_global_state" boolean handled differently from "ignore_unavailable" in the API? #4949

Closed
meconlin opened this issue Jan 30, 2014 · 3 comments
Closed

Snapshot API : Why is "include_global_state" boolean handled differently from "ignore_unavailable" in the API? #4949

meconlin opened this issue Jan 30, 2014 · 3 comments
Assignees
@imotov
Labels
>enhancement v1.0.0.RC2 v1.1.0 v2.0.0-beta1

Comments

@meconlin
Copy link

Why is "include_global_state" boolean handled differently from "ignore_unavailable" in the API?

One handles string "true"/"false" one does not?

From CreateSnapshotRequest

} else if (name.equals("ignore_unavailable") ||  name.equals("ignoreUnavailable")) {
                ignoreUnavailable = nodeBooleanValue(entry.getValue());
}

vs.

if (!(entry.getValue() instanceof Boolean)) {
                    throw new ElasticsearchIllegalArgumentException("malformed include_global_state, should be boolean");
}
@imotov
Copy link
Contributor

imotov commented Jan 30, 2014

Because I missed it. I will fix. Thanks for catching it.

@ghost ghost assigned imotov Jan 30, 2014
@meconlin
Copy link
Author

oh fun! can I fix it? love es by the way, thanks for cranking on it. The snapshot api is awesome.

@imotov
Copy link
Contributor

imotov commented Jan 30, 2014

Sure. By the way, RestoreSnapshotRequest has the same issue.

This was referenced Jan 30, 2014
Closed
Closed
@imotov imotov closed this as completed in cd9be43 Jan 30, 2014
imotov pushed a commit that referenced this issue Jan 30, 2014
@imotov
Improve boolean handling in snapshot/restore request parsing
32202d5 
Fixes #4949
imotov pushed a commit that referenced this issue Jan 30, 2014
@imotov
Improve boolean handling in snapshot/restore request parsing
69a853f 
Fixes #4949
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@imotov
Improve boolean handling in snapshot/restore request parsing
938a2c5 
Fixes elastic#4949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imotov imotov

Labels
>enhancement v1.0.0.RC2 v1.1.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle "true"/"false" in snapshot api for "include_global_state" meconlin/elasticsearch
2 participants
@imotov @meconlin