New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parent / child queries force default similarity #4977
Comments
hey @gpstathis this makes a lot of sense to me though! Would you be able to open a PullRequest for this and singe the CLA so we can pull it in? It would be great to have that in the next release which is coming very soon |
CLA is signed. Pull request #4979 is open. |
Hey @s1monw, @martijnvg, thanks for the lightning fast turnaround! I see most 0.90.11 tickets are closed. The release must be really close? ;-) |
@gpstathis really close ;) |
👍 |
yeah I guess you had a good timing @gpstathis ;) |
@martijnvg it seems that #3822 may have introduced a regression with custom similarities as well as the non-default bm25 and drf similarities. For instance, if I were to use bm25 for a child doc field, the Top Children query will not use it. It reverts back to the default similarity.
Here is a set of curl statements for reproducing:
This affects every version from 0.90.6 all the way to 0.90.11-SNAPSHOT.
A proposed fix may be to carry over the similarity configured in the IndexSearcher passed to the createWeight() methods. See gpstathis@21d4a76 for an example. All
org.elasticsearch.index.search.child
package tests pass with these modifications.The text was updated successfully, but these errors were encountered: