BytesReference.Helper should never materialize a byte[] array. #5517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementations of BytesReference.Helper.bytesEquals and bytesHashCode materialize a byte[] when passed an instance that returns `false` in `hasArray()`. They should instead do a byte-by-byte comparison/hashcode computation without materializing the array. Close elastic#5517
| } | ||
|
|
||
| // pkg-private for testing | ||
| static boolean slowBytesEquals(BytesReference a, BytesReference b) { |
There was a problem hiding this comment.
should we assert that they have the same length here?
|
LGTM except for my minor comment |
|
While we're touching this can we please make sure the hashes are compatible with Arrays.hashCode()? Right now they are not since the initial hash starts at 0, not 1. PagedBytesReference and the initial bits in BigArrays already do the right thing. |
|
I just added a new commit to change the initial hash code to 1 and add the assertion that @kimchy suggested. I'll merge soon. |
jpountz
added a commit
that referenced
this pull request
Mar 25, 2014
The current implementations of BytesReference.Helper.bytesEquals and bytesHashCode materialize a byte[] when passed an instance that returns `false` in `hasArray()`. They should instead do a byte-by-byte comparison/hashcode computation without materializing the array. Close #5517
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementations of BytesReference.Helper.bytesEquals and
bytesHashCode materialize a byte[] when passed an instance that returns
falsein
hasArray(). They should instead do a byte-by-byte comparison/hashcodecomputation without materializing the array.