[TEST] Moved wipe* methods, randomIndexTemplate & ensureEstimatedStats to TestCluster #5542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -192,7 +169,7 @@ | |||
| private static final Map<Class<?>, TestCluster> clusters = new IdentityHashMap<Class<?>, TestCluster>(); | |||
|
|
|||
| @BeforeClass | |||
| public final static void beforeClass() throws Exception { | |||
| public static void beforeClass() throws Exception { | |||
There was a problem hiding this comment.
why is this not final anymore?
There was a problem hiding this comment.
Just a warning fixed. Does it make sense to make a static method final? Could have been a separate change though.
There was a problem hiding this comment.
no worries I was just curious.
|
I left some comments but this LGTM in general |
|
I just rebased and applied changes according to the review. |
| wipeIndices("_all"); // wipe after to make sure we fail in the test that didn't ack the delete | ||
| wipeTemplates(); | ||
| wipeRepositories(); | ||
| cluster().clear(); // wipe after to make sure we fail in the test that didn't ack the delete | ||
| ensureAllSearchersClosed(); |
There was a problem hiding this comment.
should this be cluster.assertState() or something like this?
|
one small comments otherwise LGTM |
|
Moved |
|
LGTM |
…s from ElasticsearchIntegrationTest to TestCluster This is the first to make it possible to have a different impl of TestCluster (e.g. based on an external cluster) that has the same methods but a different impl for them (e.g. it might use the REST API to do the same instead of the Java API) Closes elastic#5542
javanna
added a commit
that referenced
this pull request
Mar 26, 2014
…s from ElasticsearchIntegrationTest to TestCluster This is the first to make it possible to have a different impl of TestCluster (e.g. based on an external cluster) that has the same methods but a different impl for them (e.g. it might use the REST API to do the same instead of the Java API) Closes #5542
javanna
added a commit
that referenced
this pull request
Mar 26, 2014
…s from ElasticsearchIntegrationTest to TestCluster This is the first to make it possible to have a different impl of TestCluster (e.g. based on an external cluster) that has the same methods but a different impl for them (e.g. it might use the REST API to do the same instead of the Java API) Closes #5542
javanna
added a commit
that referenced
this pull request
Mar 26, 2014
…s from ElasticsearchIntegrationTest to TestCluster This is the first to make it possible to have a different impl of TestCluster (e.g. based on an external cluster) that has the same methods but a different impl for them (e.g. it might use the REST API to do the same instead of the Java API) Closes #5542
javanna
added a commit
that referenced
this pull request
Mar 26, 2014
…s from ElasticsearchIntegrationTest to TestCluster This is the first to make it possible to have a different impl of TestCluster (e.g. based on an external cluster) that has the same methods but a different impl for them (e.g. it might use the REST API to do the same instead of the Java API) Closes #5542
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…s from ElasticsearchIntegrationTest to TestCluster This is the first to make it possible to have a different impl of TestCluster (e.g. based on an external cluster) that has the same methods but a different impl for them (e.g. it might use the REST API to do the same instead of the Java API) Closes elastic#5542
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…s from ElasticsearchIntegrationTest to TestCluster This is the first to make it possible to have a different impl of TestCluster (e.g. based on an external cluster) that has the same methods but a different impl for them (e.g. it might use the REST API to do the same instead of the Java API) Closes elastic#5542
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…s from ElasticsearchIntegrationTest to TestCluster This is the first to make it possible to have a different impl of TestCluster (e.g. based on an external cluster) that has the same methods but a different impl for them (e.g. it might use the REST API to do the same instead of the Java API) Closes elastic#5542
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first to make it possible to have a different impl of TestCluster (e.g. based on an external cluster) that has the same methods but a different impl for them (e.g. it might use the REST API to do the same instead of the Java API)