Forbid Math.abs(int/long). #5562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have had a couple of bugs because of the use of these methods without paying attention that it might return a negative value when provided with MIN_VALUE. There is one common and legitimate usage of this method in order to perform a modulo operation which would always return a positive number. This use-case has been extracted to MathUtils.mod. Close elastic#5562
|
LGTM |
jpountz
added a commit
that referenced
this pull request
Mar 27, 2014
We have had a couple of bugs because of the use of these methods without paying attention that it might return a negative value when provided with MIN_VALUE. There is one common and legitimate usage of this method in order to perform a modulo operation which would always return a positive number. This use-case has been extracted to MathUtils.mod. Close #5562
jpountz
added a commit
to jpountz/elasticsearch
that referenced
this pull request
Jun 3, 2014
Routing has been inadvertly changed in elastic#5562 resulting in documents going to different shards in 1.2. This is a terrible bug because an indexing request would not necessarily go to the same shard anymore, potentially leading to duplicates. Close elastic#6391
Closed
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Routing has been inadvertly changed in elastic#5562 resulting in documents going to different shards in 1.2. This is a terrible bug because an indexing request would not necessarily go to the same shard anymore, potentially leading to duplicates. Close elastic#6391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had a couple of bugs because of the use of these methods without paying
attention that it might return a negative value when provided with MIN_VALUE.
There is one common and legitimate usage of this method in order to perform
a modulo operation which would always return a positive number. This use-case
has been extracted to MathUtils.mod.