Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SnapshotMetaData.fromXContent does not match toXContent, but throws an Exception #5615

Closed
nkvoll opened this issue Mar 31, 2014 · 3 comments
Closed

SnapshotMetaData.fromXContent does not match toXContent, but throws an Exception #5615

nkvoll opened this issue Mar 31, 2014 · 3 comments
Assignees
@imotov
Labels
>bug v1.1.1

Comments

@nkvoll
Copy link
Member

nkvoll commented Mar 31, 2014

Is there any particular reason why fromXContent should raise an Exception, while toXContent serializes the information?

Source at https://github.com/elasticsearch/elasticsearch/blob/master/src/main/java/org/elasticsearch/cluster/metadata/SnapshotMetaData.java#L358

This seems to cause problems for certain gateways, such as elastic/elasticsearch-cloud-aws#68
@imotov imotov self-assigned this Mar 31, 2014
@imotov
Copy link
Contributor

imotov commented Mar 31, 2014

@nkvoll Thanks for the report. SnapshotMetaData doesn't implement fromXContent because it's not supposed to be serialized as part of persistent cluster state and therefore shouldn't be deserializable when cluster state is restored. I am working on a fix for this issue.

@imotov imotov mentioned this issue Mar 31, 2014
Merged
@imotov imotov mentioned this issue Mar 31, 2014
Closed
@s1monw
Copy link
Contributor

s1monw commented Apr 14, 2014

LGTM

imotov added a commit to imotov/elasticsearch that referenced this issue Apr 14, 2014
@imotov
Blob store-based gateways shouldn't serialize transient metadata
6aee50e 
Fixes elastic#5615
@imotov
Copy link
Contributor

imotov commented Apr 14, 2014

Fixed by #5628

@imotov imotov closed this as completed Apr 14, 2014
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@imotov
Blob store-based gateways shouldn't serialize transient metadata
b11a48e 
Fixes elastic#5615
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imotov imotov

Labels
>bug v1.1.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nkvoll @imotov @s1monw