New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScriptDocValues.EMPTY doesn't implement getValue
#5646
Labels
Comments
jpountz
added a commit
to jpountz/elasticsearch
that referenced
this issue
Apr 1, 2014
Instead the default implementation is used, but on top of empty (Bytes|Long|Double|GeoPoint)Values. This makes sure there is no inconsistency between documents depending on whether other documents in the segment have values or not. Close elastic#5646
+1 to just remove the empty one! |
jpountz
added a commit
that referenced
this issue
Apr 2, 2014
Instead the default implementation is used, but on top of empty (Bytes|Long|Double|GeoPoint)Values. This makes sure there is no inconsistency between documents depending on whether other documents in the segment have values or not. Close #5646
jpountz
added a commit
that referenced
this issue
Apr 2, 2014
Instead the default implementation is used, but on top of empty (Bytes|Long|Double|GeoPoint)Values. This makes sure there is no inconsistency between documents depending on whether other documents in the segment have values or not. Close #5646
jpountz
added a commit
that referenced
this issue
Apr 2, 2014
Instead the default implementation is used, but on top of empty (Bytes|Long|Double|GeoPoint)Values. This makes sure there is no inconsistency between documents depending on whether other documents in the segment have values or not. Close #5646
mute
pushed a commit
to mute/elasticsearch
that referenced
this issue
Jul 29, 2015
Instead the default implementation is used, but on top of empty (Bytes|Long|Double|GeoPoint)Values. This makes sure there is no inconsistency between documents depending on whether other documents in the segment have values or not. Close elastic#5646
mute
pushed a commit
to mute/elasticsearch
that referenced
this issue
Jul 29, 2015
Instead the default implementation is used, but on top of empty (Bytes|Long|Double|GeoPoint)Values. This makes sure there is no inconsistency between documents depending on whether other documents in the segment have values or not. Close elastic#5646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This might not look like an issue since getting a single value on something that is empty makes no sense but it introduces an inconsistency between documents that have no value, depending on whether they are on a segment that has no value at all (which will use
ScriptDocValues.EMPTY
), or on a segment where at list one document has a value. In the latter case,ScriptDocValues.Longs
(orDoubles
) will be used and these classes implementgetValue
and return a default value (0
) for documents with no value.See #4684 (comment) for the original bug report.
The text was updated successfully, but these errors were encountered: