Fix P/C assertions for rewrite reader #5731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martijnvg can you look at this? |
|
@s1monw The changes to ChildrenConstantQuery and ParentConstantQuery look good, but we should do the similar change to ChildrenQuery and ParentQuery as well. |
|
@martijnvg more cleanups :) |
|
@s1monw Thanks! and LGTM |
|
l Sent from Yahoo Mail on Android |
…n & add more assertions
Inner queries must be rewritten as soon as a weight is pulled ie. must be non-null. Closes elastic#5731
s1monw
added a commit
that referenced
this pull request
Apr 8, 2014
Inner queries must be rewritten as soon as a weight is pulled ie. must be non-null. Closes #5731
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inner queries must be rewritten as soon as a weight is pulled ie. must
be non-null.