Scroll api reduce phase fails if shard failures occur #6022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…total number of shard level requests and not the total number of requests that have a shard level result. Make sure no null TopDocs entires are passed down to TopDocs#merge Added dedicated scroll tests that tests scrolling on an index that has missing shards due to node failure. Made sure that the sort fields in SimpleNestedTests exists by adding the fields in the mapping during index creation.
| .setSource(jsonBuilder().startObject().field("field", i).endObject()) | ||
| .get(); | ||
| } | ||
| refresh(); |
|
Very nice catch! |
|
Updated the PR and addressed the feedback. |
|
LGTM |
martijnvg
added a commit
that referenced
this pull request
May 8, 2014
…urred: * The shardTopDocs array should get created with the size equal to the total number of shard level requests and not the total number of requests that have a shard level result. * Make sure no null TopDocs entires are passed down to TopDocs#merge * Added dedicated scroll tests that tests scrolling on an index that has missing shards due to node failure. * Made sure that the sort fields in SimpleNestedTests exists by adding the fields in the mapping during index creation. Closes #6022
clintongormley
added
the
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only occurs in 1.x and master branches and not in any released versions.