Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in PropertyPlaceholder and add unit tests #6034

Closed
wants to merge 1 commit into from
Closed

Fix bug in PropertyPlaceholder and add unit tests #6034

wants to merge 1 commit into from

Conversation

Paikan
Copy link
Contributor

@Paikan Paikan commented May 4, 2014

This pull request includes the following changes:

  • Fix bug in PropertyPlaceholder when prefix and suffix have same length or suffix is longer than prefix
  • Add unit tests for the PropertyPlaceholder class. testNestedSameLengthPrefixSuffix and testNestedShorterPrefix failed before this bug fix.

@jpountz jpountz self-assigned this May 5, 2014
jpountz pushed a commit that referenced this pull request May 5, 2014
@jpountz jpountz closed this in cea2d21 May 5, 2014
jpountz pushed a commit that referenced this pull request May 5, 2014
@jpountz
Copy link
Contributor

jpountz commented May 5, 2014

Merged. Excellent change, thanks!

@Paikan Paikan deleted the fix-bug-property-placeholder branch May 5, 2014 08:43
@clintongormley clintongormley added the :Core/Infra/Settings Settings infrastructure and APIs label Jun 7, 2015
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants