Remove operation threading from broadcast actions #6044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to search removal, the operation threading options are not really ued, and the default should always be used. This also considerably simplifies the code. A side affect is that we can now remove the ShardIterator#firstOrNull method, which can cause for sneaky bugs to occur. closes elastic#6044
| @@ -234,7 +234,7 @@ public void onFailure(Throwable e) { | |||
| // Redirects the request to a data node, that has the index meta data locally available. | |||
| private void redirect(MoreLikeThisRequest request, String concreteIndex, final ActionListener<SearchResponse> listener, ClusterState clusterState) { | |||
| ShardIterator shardIterator = clusterService.operationRouting().getShards(clusterState, concreteIndex, request.type(), request.id(), request.routing(), null); | |||
| ShardRouting shardRouting = shardIterator.firstOrNull(); | |||
| ShardRouting shardRouting = shardIterator.nextOrNull(); | |||
There was a problem hiding this comment.
unrelated but should it retry on the next shard in the iterator in case of a failure?
There was a problem hiding this comment.
yea, it would be nice to have that!
|
LGTM |
kimchy
added a commit
that referenced
this pull request
May 5, 2014
Similar to search removal, the operation threading options are not really ued, and the default should always be used. This also considerably simplifies the code. A side affect is that we can now remove the ShardIterator#firstOrNull method, which can cause for sneaky bugs to occur. closes #6044
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to search removal, the operation threading options are not really ued, and the default should always be used. This also considerably simplifies the code.
A side affect is that we can now remove the ShardIterator#firstOrNull method, which can cause for sneaky bugs to occur.