Before deleting a local unused shard copy, verify we're connected to the node it's supposed to be on #6191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the node it's supposed to be on This is yet another safety guard to make sure we don't delete data if the local copy is the only one (even if it's not part of the cluster state any more)
|
LGTM though - do we have the chance to get a test that reflects the problem or the reason we add this? |
|
@s1monw this is caused by a rare race condition in cluster state processing which the reason for infrequent failures on our PS. I bumped the labels from 1.2.0 to 1.3.0 so there is no rush. |
|
cool lets get this into |
bleskes
added a commit
that referenced
this pull request
May 20, 2014
…the node it's supposed to be on This is yet another safety guard to make sure we don't delete data if the local copy is the only one (even if it's not part of the cluster state any more) Closes #6191
clintongormley
changed the title
clintongormley
added
the
:Distributed/Recovery
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is yet another safety guard to make sure we don't delete data if the local copy is the only one (even if it's not part of the cluster state any more)